On Wed, 20 Sep 2000, stephen noble wrote:
> i've made an enhancement to charlies dialin rpm, it now has a gui and more
> options, and doesn't require any manual setting of parameters,
> it installs and uninstalls well, and modifies the config files, but it hasn't
> been dialed into so you could say it's alpha
Thanks for the contribution, Stephen.
A few comments based on a quick examination of the source RPM.
- The tarball contains symlinks. It shouldn't, because symlinks cannot be
removed using the patch command. This is why we create symlinks using the
"createlinks" part of the build process.
- The tarball contains e-smith-0.2-filelist. It shouldn't, because this
file is created as part of the RPM build process. It's not too much of a
problem that the tarball contains this file, but it is wasteful, and may
be confusing.
- The tarball contains a file called .directory. This appears to be an
artefact of the KDE file manager. It is unnecessary.
To remove the symlinks and these files from the tarball, do:
cd BUILD
tar xzvf ../SOURCES/e-smith-dialin-0.2.tar.gz
find e-smith-dialin-0.2 -type l | xargs rm \
e-smith-dialin-0.2/e-smith-0.2-filelist e-smith-dialin-0.2/.directory
tar czvf ../SOURCES/e-smith-dialin-0.2.tar.gz e-smith-dialin-0.2
- inittab/60dialup. This looks to me as though it won't work if
DialinPausedx is defined in the configuration. IIRC, labels in inittab are
limited to two characters. [Ah, having looked further down, I see that the
only expected value of DialinPausedx is "#".]
OTOH, I think this fragment will generate a warning about uninitialised
variable use if DialinPausedx is not defined.
- web/functions/dialin. Only had a quick look at this. There are some
missing spaces where you concateate strings, e.g.
($q, $q->p ('You can configure or start/shut down your dialin server',
'from this screen. Select the port your modem is attached to,',
'assign an unused IP address to the dialin client, select if you want ',
This will display as "down your dialin serverfrom this screen", and "is
attached to,assign an unused"..
- Looks like the web interface is a great contribution, Stephen.
- Now some comments about netiquette. It's "traditional" to contribute
patches to the original author, rather than post your own version. See
http://www.tuxedo.org/~esr/writings/homesteading/homesteading/. In fact,
it might be seen that you have broken all three taboos listed in
http://www.tuxedo.org/~esr/writings/homesteading/homesteading/x97.html.
Please at least credit me as the original author in your web page.
Charlie Brady [EMAIL PROTECTED]
http://www.e-smith.org (development) http://www.e-smith.com (corporate)
Phone: +1 (613) 368 4376 or 564 8000 Fax: +1 (613) 564 7739
e-smith, inc. 1500-150 Metcalfe St, Ottawa, ON K2P 1P1 Canada
