On Mon, 28 Nov 2016 22:22:39 +0100 Martin Pitt <martin.p...@ubuntu.com> wrote:
> Tomáš Smetana [2016-11-28 14:09 +0100]: > > One thing we miss at the moment is some good communication channel. Github > > does not have mailing lists and since storaged is not a Freedesktop > > project we didn't feel like discussing our stuff here. Perhaps this ML > > list would be a good place to discuss the project's merge. > > "devkit-devel" is certainly an odd name in 2016, but as it happens it > probably has the right people subscribed, so as there doesn't seem to > be any parallelism in that regard it seems fine to (continue to) use > this list. Good. First problem solved. > > The tests we actually run are these: > > https://github.com/storaged-project/storaged/tree/master/src/tests/dbus-tests > > > > These look nice, although they seem to require real block devices from > targetcli_config.json? There's surely quite some overlap with > src/tests/integration-test, that seems one good target for cleanup > after the unification. The block devices are still fake in the sense we create them specially for the tests. But we're faking them with iSCSI since scsi_debug devices all share the same backing store thus behaving more like multipath. That was breaking some of the tests (LVM)... As for the integration-test: I used it for "inspiration" for the first new ones and I think it still may serve that purpose. I believe Vratislav et al. are now working on moving the tests to the new format. > > > * At some point I should probably become a storaged project member, > > > but there is no urgency -- everyone including project members > > > should always use PRs anyway. > > > > Yes. We have actually decided to let every non-trivial PR unmerged for > > some time so people get chance to add their comments and reviews. > > Even for trivial ones it's good to let CI run before landing. > (http://imgur.com/mJT7sDs) True. > > > So it seems that renaming "storaged" to "udisks" would be the simpler > > > alternative as it would not require changes to external > > > software/packages. If you prefer to keep "storaged", then I think it's > > > better to rename the D-Bus API/library/ABI consistently and port the ~ > > > 30 users of it (at least that's how many we have in Debian) to the new > > > names. > > > > I don't know how it works in Debian: this is mostly non-issue on > > Fedora/RHEL so I don't really care as long the result is usable and > > working from the user's perspective. > > Usable, yes: Our preliminary Debian packages for storage also use the > Provides: mechanism. However, it's still confusing to have a > "storaged" package and everything inside (binaries, D-Bus method, and > even user-facing CLI) say "udisks" everywhere. Calling it udisks would be simpler for sure: No changes would be required in the code itself and no dependencies would need to be ported. I only like the storaged name more and as Vratislav put it: the goal is to develop the storage daemon. And.. by chance, does some of the udisks developers plan to attend devconf.cz in January? Regards, -- Tomáš Smetana _______________________________________________ devkit-devel mailing list devkit-devel@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/devkit-devel
