Aesthetics aside, I don't see how this can make the problem worse. When the node runs out of threads it is practically dead (upstream bandwidth is typically a few hundred bytes/sec or less). Some connections get killed and the node is able to carry on and be usefull. Othwise, this condition can literally persist for HOURS (depends on how busy the node is). This then forces the network to route around the node which hurts performance for everyone (possibly causing DNF's). The test is simple, if upstream bandwidth is very low and there are alot of freenet.node.states.data.DataStateInitiator threads, then kill some of said threads, starting with the ones idle the longest. If none are idle, kill some freenet.node.states.data.DataStateInitiator threads with the lowest transfer rates. I understand that this is an ugly hack, but I don't understand how it could make things worse since it would only happen when the node is basically dead.
----- Original Message ----- From: "Toad" <[EMAIL PROTECTED]> To: "Discussion of development issues" <[EMAIL PROTECTED]> Sent: Monday, September 01, 2003 7:45 PM Subject: Re: [freenet-dev] Threads / Performance / File System Start Time On Mon, Sep 01, 2003 at 06:13:00PM -0700, pineapple wrote: > Asynchronos data transfers are not the only solution, > they are just the best solution. Killing threads in > an overload situation is an ugly hack, but its > something that could be done right now, as opposed to > improvments to NIO which could be a ways off. I agree > that this is an ugly band-aid solution, but what is > wanted right now is something quick and dirty to hold > us over until the NIO improvements. Not doing the best solution makes us vulnerable to low bandwidth DoS. And the proposed hack is far worse than the problem it is addressing. -- Matthew J Toseland - [EMAIL PROTECTED] Freenet Project Official Codemonkey - http://freenetproject.org/ ICTHUS - Nothing is impossible. Our Boss says so. > _______________________________________________ > Devl mailing list > [EMAIL PROTECTED] > http://dodo.freenetproject.org/cgi-bin/mailman/listinfo/devl __________________________________ Do you Yahoo!? Yahoo! SiteBuilder - Free, easy-to-use web site design software http://sitebuilder.yahoo.com _______________________________________________ Devl mailing list [EMAIL PROTECTED] http://dodo.freenetproject.org/cgi-bin/mailman/listinfo/devl
