On Tue, 2003-09-30 at 21:38, Ian Clarke wrote: > On Tue, Sep 30, 2003 at 07:26:23PM -0400, Ed Tomlinson wrote: > > > It looks like it is reporting the size, but shouldn't it be reporting > > > the time? > > It looks very much like it should be read: > > rtTransferFailed.report(time); > > good catch. > > I won't be 100% sure until Toad verifies this,
find . -name '*.java' -print0 | xargs -0 grep -n transferFailed |
grep -i key
./src/freenet/node/rt/NGRouting.java:161:
last.transferFailed(key, System.currentTimeMillis() - lastTime, size);
./src/freenet/node/rt/NodeEstimator.java:63:
abstract public void transferFailed(Key key, long time, long size);
./src/freenet/node/rt/StandardNodeEstimator.java:217:
public void transferFailed(Key key, long time, long size) {
The only call is NGRouting.java:161, and the second argument
is obviously a time and the third is the size argument to
NGRouting.transferFailed().
lastTime is a member of class NGRouting. It is set to
System.currentTimeMillis() in getNextRoute(), routeConnected(),
verityFailed(), queryRejected(), and dataNotFound().
So the value being averaged in rtTransferFailed was definitely
not a time, and now it is. But does transferFailed() also get
called after VF, QR, or DNF?
-- Ed Huff
signature.asc
Description: This is a digitally signed message part
_______________________________________________ Devl mailing list [EMAIL PROTECTED] http://dodo.freenetproject.org/cgi-bin/mailman/listinfo/devl
