On Fri, 2003-10-17 at 15:32, Toad wrote: > On Fri, Oct 17, 2003 at 03:22:10PM -0400, Edward J. Huff wrote: > > On Fri, 2003-10-17 at 14:06, Toad wrote: > > > On Thu, Oct 16, 2003 at 08:46:48PM -0700, Edward J. Huff wrote: > > > > Update of /cvsroot/freenet/freenet/src/freenet/thread > > > > In directory sc8-pr-cvs1:/tmp/cvs-serv8030 > > > > > > > > Modified Files: > > > > ThreadFactory.java > > > > Log Message: > > > > Added mode line. Changed comment on getThread to reflect > > > > the fact that some implementations might return null. > > > > > > No, don't do that. That requires rewriting hundreds or thousands of lines > > > of code for no good reason. > > > > No, I checked. There were two places where the return value > > was used, both of them only if logDEBUG in order to print the > > name of the thread. Both of them are fixed so they won't get NPE > > but will just not print the thread name (which is useless anyway). > > But if it returns null, it means the job won't be executed? What are the > consequences of that? In the ticker, it could be pretty bad.
No, it just means that the job hasn't been assigned to a specific thread yet. It might get a newly created thread, or it might get one which comes back before the job has been on queue more than tolerableQueueDelay milliseconds. > > > > > > > > > > > > > > Index: ThreadFactory.java > > > > =================================================================== > > > > RCS file: /cvsroot/freenet/freenet/src/freenet/thread/ThreadFactory.java,v > > > > retrieving revision 1.8 > > > > retrieving revision 1.9 > > > > diff -u -w -r1.8 -r1.9 > > > > --- ThreadFactory.java 8 Feb 2003 03:25:55 -0000 1.8 > > > > +++ ThreadFactory.java 17 Oct 2003 03:46:46 -0000 1.9 > > > > @@ -1,3 +1,4 @@ > > > > +/* -*- Mode: java; c-basic-indent: 4; tab-width: 4 -*- */ > > > > package freenet.thread; > > > > import java.io.PrintWriter; > > > > > > > > @@ -26,6 +27,8 @@ > > > > > > > > /** > > > > * @param r the job to run > > > > + * @return the thread executing the job, or null if the > > > > + * job was queued. > > > > */ > > > > Thread getThread(Runnable r); > > > > _______________________________________________ Devl mailing list [EMAIL PROTECTED] http://dodo.freenetproject.org/cgi-bin/mailman/listinfo/devl
