Update of /cvsroot/freenet/freenet/src/freenet/crypt/ciphers
In directory sc8-pr-cvs1:/tmp/cvs-serv25857/src/freenet/crypt/ciphers
Modified Files:
Tag: stable
Rijndael_Algorithm.java
Log Message:
5029: Merge from unstable after months of work. MASSIVE changes.
Highlights:
* Next Generation Routing, massive related changes
* Major changes to handling of messages and connections (PeerHandler and related
changes)
* Even more non-blocking I/O
* Documentation improvements
* Lots of new diagnostics and config options
* Lots of bug fixes and performance tweaking
* Probably lots of new bugs too!
Index: Rijndael_Algorithm.java
===================================================================
RCS file: /cvsroot/freenet/freenet/src/freenet/crypt/ciphers/Rijndael_Algorithm.java,v
retrieving revision 1.4.4.2
retrieving revision 1.4.4.2.2.1
diff -u -w -r1.4.4.2 -r1.4.4.2.2.1
--- Rijndael_Algorithm.java 4 Mar 2003 20:30:38 -0000 1.4.4.2
+++ Rijndael_Algorithm.java 28 Oct 2003 20:20:30 -0000 1.4.4.2.2.1
@@ -501,7 +501,17 @@
* @param blockSize The block size in bytes of this Rijndael.
* @exception InvalidKeyException If the key is invalid.
*/
- public static final synchronized Object makeKey (byte[] k, int blockSize)
+ //TODO: This method doesn't really need synchronization. The only reason
+ //I can see for it to be synchronized is that it will consume 100% CPU (due to
+ //heavy calculations) when called. Probably should be unsynchronized if we
+ //want better support for dual+ CPU machines. /Iakin 2003-10-12
+ //Concur: the class has no fields which are not final, and does
+ //not reference fields of any other classes. Control over how
+ //many simultaneous makeKey invocations should be allowed is
+ //a problem the callers should resolve among themselves.
+ //It is a fact that allowing no more than one makeKey on any given
+ //CPU will result in fewer cache misses. -- ejhuff 2003-10-12
+ public final static synchronized Object makeKey (byte[] k, int blockSize)
throws InvalidKeyException {
if (RDEBUG) trace(IN, "makeKey("+k+", "+blockSize+")");
if (k == null)
_______________________________________________
cvs mailing list
[EMAIL PROTECTED]
http://dodo.freenetproject.org/cgi-bin/mailman/listinfo/cvs
