On Mon, 11/10/03 at 18:12:03 +0000, Toad wrote: > On Sun, Nov 09, 2003 at 12:33:48PM -0800, Brandon Low wrote: > > Update of /cvsroot/freenet/freenet/src/freenet/node/rt > > In directory sc8-pr-cvs1:/tmp/cvs-serv21891/freenet/src/freenet/node/rt > > > > Modified Files: > > NGRoutingTable.java > > Log Message: > > Change how rt nodes are removed from the rt. This sorting seems to make more > > sense logically, and in practice, it's significantly improved the apparent quality > > of my route. > > This needs more testing, but looks good. Using the number of successes > is fine as long as it's a last resort. consecutiveConnectionFailures is > 0 if we have any open connections, even if we have some conn failures; > I'm uncertain whether moving it below lastSuccess is entirely valid but > hopefully it will work better in practice.
This was basically to prevent us from immediately dropping a node from our rt if it is in the process of a restart. Nodes take up to 10 minutes to do a restart for a simple build change, and since build changes on unstable are not infrequent events, this would lead to us dropping such nodes from the rt regularly. Sorting based on the last success instead will keep a node who recently transfered something to us successfully in the rt even if it goes down for a reasonable time period, only after something in the order of 5 minutes has passed will it fall toward the ass end of the sorting and be dropped based on the number of rejections. Anywho, it works really well for my node, hope it proves helpful otherwhere in the network. It should be noted that the credit for narrowing down the need goes to supple on IRC, he was watching his rt and noticed that the apparent best nodes would be removed apparently without reason from time to time, after some investigation, I determined that this was because there are plenty of nodes out there that suck, but which are always up, these nodes will stay in the rt forever while better nodes that restart sometimes will be kicked off. --Brandon _______________________________________________ Devl mailing list [EMAIL PROTECTED] http://dodo.freenetproject.org/cgi-bin/mailman/listinfo/devl
