Welcome! Another experienced Java and Mac dev will come in handy =) On Dec 22, 2010 7:50 AM, "Richy (Wired Up and Fired Up)" < [email protected]> wrote: > Hi, > > Great project and I hope I can be of some help. I've been developing java systems, initially in the banking sector - more recently all over the show but mostly large scale web projects since the late '90s and I also build Mac/iPhone apps. > > Anyway, the first thing I noticed on installing Freenet 0.7.5 on OS X (10.6.2) was that I received the warning "Upgrade your Java immediately! Freenet has disabled important functions including search to limit damage due to a severe vulnerability in your outdated Java version!" (I saw a few users have reported this on the support list as well) > > Odd, I was pretty sure that I was more or less up to date.. Anyway, running java -version gave the following : > > java version "1.6.0_17" > Java(TM) SE Runtime Environment (build 1.6.0_17-b04-248-10M3025) > Java HotSpot(TM) 64-Bit Server VM (build 14.3-b01-101, mixed mode) > > I isolated and ran the code in Node.java (using the default JVM) that should trigger this warning but it didn't appear to, so I figured that there must be something in the wrapper config or similar overriding the choice of JVM. > > In run.sh (line #158 onwards) there is an if statement that selects the 1.5.0 version if it exists. By changing the JAVA_HOME export to /System/Library/Frameworks/JavaVM.framework/Versions/1.5.0 and rerunning my test of Node.js the warning is triggered. > > This made sense for my install as the JVM in that location is version 1.5.0_19 and should trigger the warning. > > Replacing this if statement with simply : > export JAVA_HOME="/System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home" > > Or commenting out the entire thing, fixes this as the default java home on OS X is a mess of symlinks that eventually arrive at /System/Library/Frameworks/JavaVM.framework/Versions/CurrentJDK/Home anyway. > > By default CurrentJDK should be pointing at the latest version installed on the machine, whereas 1.5.0 won't necessarily. > > I think, out of preference I'd remove this statement entirely. This will give the user the option to set either their JAVA_HOME themselves and/or manage their own JVM installs (say, for those using openjdk or other 'non-apple' java versions, which by the looks of it will soon be everyone...) plus, for now, at least in recent versions of os x the default behavior is correct. > > I'm still new to the code and it's layout and haven't actually managed to get it to build yet.. (git clone and ant bails out) So I don't have a patch or anything I can send for this, but just thought I'd send it over in the hope that it will help :) > > In the meantime, I'd just like to say 'hi' and I'll carry on messing about with the build and trying to familiarise myself with what is already there, as I said I hope to be able to make a contribution as time goes on and will probably pop up again sooner or later either here or on irc looking for some direction into where I can help out. > > Cheers, > > Richy > _______________________________________________ > Devl mailing list > [email protected] > http://freenetproject.org/cgi-bin/mailman/listinfo/devl
_______________________________________________ Devl mailing list [email protected] http://freenetproject.org/cgi-bin/mailman/listinfo/devl
