On Sunday 12 May 2013 12:37:28 [email protected] wrote: > Please review: > > https://bugs.freenetproject.org/file_download.php?file_id=311&type=bug
Okay, one or two things to deal with first: - It would be better to just say which branch you want us to merge. There is a button for this on github, otherwise post a link. (The link you posted in the first commit was wrong) - You should always use git diff -u --ignore-space-change - Calling reportMTU inside the loop is a bit odd, but I guess it's unavoidable? I believe IPv4 and IPv6 on the same interface is how it will generally work, in which case the JVM should report whichever MTU is lower? This should be mentioned in the comments anyway. - Freenet typically uses a style of 4 space tabs and 100 char lines IIRC. So you are chopping off some lines unnecessary. Hmmm, I thought there was a page for this on the wiki? Apparently not ... :| - Once this is deployed we should update the plugin as well... > > Thanks, > Vmon > > [email protected] writes: > > > Still need to ignore local ips but that shouldn't be hard. I'll add that > > shortly. Also it calls updateMTU more frequently. I don't know if it is > > a deal breaker. > > > > Anyway, I ran it and at least I was able to browse normally so I haven't > > broke anything. > > > > https://github.com/vmon/fred-staging/commit/1b108d0c0210731c5424af0e36415a867004b5c1 > > > > Cheers, > > Vmon
signature.asc
Description: This is a digitally signed message part.
_______________________________________________ Devl mailing list [email protected] https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
