I was busy through the semester and couldn't work due to various reasons. But, started to work on it during the summers.
I've fixed most issues pointed out by Steve. The following issues remain to be fixed: 1)reordering the code 2)multiple catch statements 3)(importantly) removing debug code and writing clean logs. Some code use java logger, it needs to be replaced by normal one. I'll be working on these this week and try to give a detailed reply to the feedback by the end of this week Nitesh On 16-Jun-2014 9:36 am, "xor" <x...@freenetproject.org> wrote: > -----BEGIN PGP SIGNED MESSAGE----- > Hash: SHA256 > > On Saturday, December 28, 2013 01:45:10 PM Steve Dougherty wrote: > > I've been reviewing the darknet node reference exchange Android > > application and associated patches. Nitesh, would you like to > > participate in this review? I've attached feedback on the Fred and > > MDNSDiscovery patches. > > > > I haven't done code review in this kind of situation, so if there's a > > better way to do it I'd be happy to hear it. Some issues are just > > cosmetic, and others are design or readability problems. Sometimes it's > > not clear whether something is actually correct. > > > > Thanks, > > Steve > > Whats the progress with this? > -----BEGIN PGP SIGNATURE----- > Version: GnuPG v2.0.22 (GNU/Linux) > > iQIcBAEBCAAGBQJTnm0qAAoJEMtmZ+8tjWt5iL4QAI/OJdJjL4PzsWvwAEbhRtdY > gKogPaYuB+Q+JjRp0s2dQZ3mMCyA7UtbGFSPMNHrprDd3R+euP0v2vAxy7EyBpBE > KmmTBG6OGO+EkgFGFzSTcXA7Zs7NVhQm9OdBZrbcnn5B/iMO+SpPxndO+cHVAKF5 > xa7PnbhncgJPn1dZaRNbIbHjzf9zyhJ2keyo5J+7170YsRKAlM/YEKTLSELaIyAM > VK0WKkzB5Q6oq7RuZ+bBpDwF45Sx0ZtanE0UpztyedeGyjaosO5IT0IpYBU5NIyo > 772AqCw+OBXPvQbVQZOXB2ZQmCbM70RX9kB515XHFtq1mkJdj4n7gp85MNnph80u > e3XUM2+4bQN7FuJKZfNW+H7VQ8IcsR2Sx3ptwjtIICELv8N7zFUsftFAYuKVsos7 > Orx6NGeVcqd1JfLE1glzQj2ESO+bRE9uJDu5rDRt/1ADW8yaQ8nIAi3pudKyj0bd > JxUiCWFsApoveEFAk15KAqDW8tSvWaZ/BAsW4YZm4rJYVumP++DnhQkNMLeaCRV9 > kkyrXBtHauAsAcOXJl16YAvKEeszDxSpapPQN9/UwhTRqONdV0f/M8F7vcgBO7bW > mLH+NxW+w5QWG1uqgPRuMCWqbOef87s7o3QPtNVNRLuR2JGXfsCgBRxsYxzXMFuG > vzEv6GkyLfXClYFc0dyu > =jIAB > -----END PGP SIGNATURE----- > _______________________________________________ > Devl mailing list > Devl@freenetproject.org > https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl > _______________________________________________ Devl mailing list Devl@freenetproject.org https://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
