On Sat, 15 Apr 2000, Theodore Hong wrote:
> The constructor for the SentCB class in DataSend.java looks like this:
>
> public SentCB(Node n, Key k) {
> this.n = n;
> this.k = k;
> this.dataSource = DataSend.this.dataSource;
> }
>
> Is there any particular reason why the dataSource is being set as
> DataSend.this.dataSource? In the interests of clarity, I'd rather
> pass it in as an explicit argument, if no one else minds.
The reason was simply that the SentCB cannot be static anyways, so there is no
need for the extra argument. But it doesn't really matter either.
In light of your changes to the code yesterday, could you please write
something to the list when you make a large change or add a new feature to the
cvs about what you have added and what classes are effected (as I have attempted
to do). Not that I have any objections to the storeable fields, in fact it all
looks great and was just what I needed to start experimenting with CHKs (hear
Ian scream) but still.
Also, was there any reason to use the deprecated save() method of properties
rather then store() (they do the same thing according to the java docs)? We are
trying to avoid deprecated api when it isn't necessary...
>
> theo
>
>
>
> _______________________________________________
> Freenet-dev mailing list
> Freenet-dev at lists.sourceforge.net
> http://lists.sourceforge.net/mailman/listinfo/freenet-dev
--
Oskar Sandberg
md98-osa at nada.kth.se
#!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj
$/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1
lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/)
_______________________________________________
Freenet-dev mailing list
Freenet-dev at lists.sourceforge.net
http://lists.sourceforge.net/mailman/listinfo/freenet-dev
