The problem is the numbers are different in InsertClient and RequestClient for handshakeTimeout. If you start both at the same time in the same JVM one could get the wrong number.
Another problem is we are duplicating the same code in 4 places. If someone changes it in one place they don't know to change it in the other places. Maybe we should initialize them at their declarations? If we do this the differences between InsertClient and RequestClient need to be resolved. Sorry if I was unclear, Paul > From: Oskar Sandberg <md98-osa at nada.kth.se> > Reply-To: freenet-dev at lists.sourceforge.net > Date: Mon, 24 Apr 2000 17:51:38 +0200 > To: freenet-dev at lists.sourceforge.net > Subject: Re: [Freenet-dev] Unacceptable globals (static) > > > I don't see the issue. These variables need to be set only once, and that is > when you start up Freeloader (an possibly if someone edits an "options" menu). > I > don't see why you would need to reset them for every Insert and Request. That > is the reason they are in the main method of the CLI clients, they should be > set in the main method the GUI client as well. > > On Mon, 24 Apr 2000, Paul Kappler wrote: >> The following values being set in the clients the way they are make in >> impossible for one jvm to handle simultaneous insert and request commands >> correctly in a GUI. There is a chance of getting the wrong value. These >> need to made non-static variables. It would also be nice if when values >> like this are added it could be done inside the insertClient and >> requestClient constructors so SimpleInsertClient does not need to mirror >> code this type. >> >> >> >> From InsertClient...There is similar in RequestClient. >> Core.connectTimeout=10000; >> Core.connectionTimeout=600000; >> Core.handshakeTimeout=10000; >> Core.handshakeLife=1000000; >> Core.hopTimeExpected=12000; >> Core.hopTimeDeviation=12000; >> Core.timer=new Ticker(500); >> Core.transience=true; >> Logger.threshold=Logger.NORMAL; >> >> >> I think they should be put on the command line and/or in the config file >> along with making them member variables. We need to rethink haw this is >> setup. >> >> What do you think? >> >> Paul >> >> Note: At the moment freeloader has been broken by additions to the code >> above. That is what inspired this note. >> >> >> _______________________________________________ >> Freenet-dev mailing list >> Freenet-dev at lists.sourceforge.net >> http://lists.sourceforge.net/mailman/listinfo/freenet-dev > -- > > Oskar Sandberg > > md98-osa at nada.kth.se > > #!/bin/perl -sp0777i<X+d*lMLa^*lN%0]dsXx++lMlN/dsM0<j]dsj > $/=unpack('H*',$_);$_=`echo 16dio\U$k"SK$/SM$n\EsN0p[lN*1 > lK[d2%Sa2/d0$^Ixp"|dc`;s/\W//g;$_=pack('H*',/((..)*)$/) > > _______________________________________________ > Freenet-dev mailing list > Freenet-dev at lists.sourceforge.net > http://lists.sourceforge.net/mailman/listinfo/freenet-dev _______________________________________________ Freenet-dev mailing list Freenet-dev at lists.sourceforge.net http://lists.sourceforge.net/mailman/listinfo/freenet-dev
