I agree, but I think you are exaggerating the current problem. It is obvious
from those problems that somebody (Brandon?) just forgot to do add a new class
when commiting. It is an easy mistake to make, and doesn't really have anything
to do with whether it is tested or not...

On Wed, 24 May 2000, Ian Clarke wrote:
> Firstly - a dependency on gnu.regexp has been introduced - we can't do
> this (certainly not without wider consultation).  If our users are
> required to download a wealth of libraries before running Freenet is
> will serve as a significant disincentive to installing the software. 
> Also, I can't really see why we would need to use regular expressions in
> the current functionality.  If you really need to use external libraries
> *integrate them into the Freenet tree*.
> 
> ---------
> Building Freenet server... node/StandardMetadataStore.java:15: Package
> gnu.regex
> p not found in import.
> import gnu.regexp.*;
>        ^
> ---------
> 
> Here it seems that someone forgot to check in some classes:
> ---------
> message/MetadataInsert.java:9: Superclass Freenet.message.Broadcast of
> class Fre
> enet.message.MetadataInsert not found.
> public class MetadataInsert extends Broadcast
>                                     ^
> node/MetadataQueryParser.java:23: Class Freenet.node.SyntaxException not
> found i
> n throws.
>   static public boolean eval(String s, FieldSet h) throws
> SyntaxException
>                                                           ^
> node/MetadataQueryParser.java:72: Class Freenet.node.SyntaxException not
> found.
>           else throw new SyntaxException();
>                          ^
> node/MetadataQueryParser.java:94: Class Freenet.node.SyntaxException not
> found.
>     else throw new SyntaxException();
>                    ^
> ----------
> 
> I cannot stress enough the fact that the code in CVS must build - out of
> the box - at all times - if you haven't completed *and tested* your
> changes DON'T CHECK THEM IN UNTIL YOU HAVE!  This is not just for the
> sake of users, but it is irritating and frustrating for other developers
> when they need to debug someone else's code before they can do any work
> themselves.  Now that there are a number of people working on the code
> following CVS etiquette is more important than ever.
> 
> Ian.
> 
> _______________________________________________
> Freenet-dev mailing list
> Freenet-dev at lists.sourceforge.net
> http://lists.sourceforge.net/mailman/listinfo/freenet-dev
-- 

Oskar Sandberg
md98-osa at nada.kth.se

_______________________________________________
Freenet-dev mailing list
Freenet-dev at lists.sourceforge.net
http://lists.sourceforge.net/mailman/listinfo/freenet-dev

Reply via email to