On Saturday 29 December 2001 16:15, you wrote:
> On Fri, Dec 28, 2001 at 01:17:27PM -0500, Gianni Johansson wrote:
> > Also, there was something I didn't get in DirectoryRoot.update.  It looks
> > like you inc root_no  and proceed even if there's an exception.  It seems
> > like you should be rolling back.  Can't this cause you to  trash the last
> > known consistant version of the accounting data on disk?
>
> root_no is already pointing to the next slot that should be written to
> (i.e., the last consistent version is at root_no-1).  it is only
> incremented as the last instruction in update(), so there is no
> increment if an exception is thrown.
Duh. You're right. 
-- 
Freesites
(0.3) freenet:MSK at SSK@enI8YFo3gj8UVh-Au0HpKMftf6QQAgE/homepage//
(0.4) freenet:SSK at npfV5XQijFkF6sXZvuO0o~kG4wEPAgM/homepage//

_______________________________________________
Devl mailing list
Devl at freenetproject.org
http://lists.freenetproject.org/mailman/listinfo/devl

Reply via email to