On Friday 21 September 2001 17:05, Oskar wrote: > On Fri, Sep 21, 2001 at 03:08:30PM -0400, Gianni Johansson wrote: > > On Friday 21 September 2001 00:21, Zlatin wrote: > > > Hi Gianni, > > > I was looking at the minor log of build 405 and it > > > struck me that at random times the CP is reduced twice > > > due to an authentication error. Then I checked it > > > with the latest 404 and it behaved the same way. Here > > > are two portions of the log file. I'm sending this to > > > you since you added that modification to the code. > > > > I don't see what the issue is here. Separate attempts were made to > > negotiate a connection with the target node on different threads. > > Each failed, so each decrements the CP. > > No, this is what I tried to tell you on IRC, you are decreasing the CP > in OpenConnectionManager, which is the wrong place to do it (as made > obvious by the VERY ugly casting of the Core object - please don't tell > me you don't see why that is unacceptable) - but it is already occuring > on line 308 in Freenet.node.states.request.Pending. The problem was > that some terminal errors were being labeled as non-terminal. which is > what should have been fixed. > > The reason it occurs in different threads is that connection is made in > a seperate thread (for the timeout).
Zlatin: Sorry for the bad information. Oskar: I never claimed that this was anything more than a hack. I told ian as much before I committed it. I thought you were going to clean it up. http://irclogs.espnow.com/freenet-logs/show_file.php?logfile=2001_09_16.log [00:25:50] <giannij> hobx: Do you want to fix it? ... [00:26:14] <hobx> no, but I can I guess. --gj -- Freesites (0.3) freenet:MSK at SSK@enI8YFo3gj8UVh-Au0HpKMftf6QQAgE/homepage// (0.4) freenet:SSK at npfV5XQijFkF6sXZvuO0o~kG4wEPAgM/homepage// _______________________________________________ Devl mailing list Devl at freenetproject.org http://lists.freenetproject.org/mailman/listinfo/devl
