Hi Matthew, Bombe:
I checked in an initial version of the the SplitFileRequestServlet
built around AutoRequester. It is less polished than I would like,
but I think it's good enough so you can start working on cleaning up
UI.
To try it out uncomment the lines:
//if (splitFile != null) {
// // REDFLAG: Need to reconstruct query values in redirect.
// resp.sendRedirect("/servlet/SFRequest/" + uri);
// return;
//}
in FproxyServlet.doGet and add the config lines in the comments above
them to your freenet.conf.
It does work. It hasn't been extensively tested, especially not with
large multi-segment SplitFiles.
Open Issues:
- anonymity filtering isn't implemented.
There are already hooks for it. See SplitFileRequestServlet.filterData().
I think Matthew can probably put this in relatively quickly.
- It downloads all the data from freenet before sending any of it. i.e. it
doesn't send the data per segment like the current fproxy code does. It
probably wouldn't be that hard to put the per segment streaming back in.
- retrying of the initial request for the SplitFile metadata isn't
implemented. I don't think this will be an issue, because normally the data
should be cached, Since SFRS only gets a request after fproxy has
successfully retrieved the SplitFile metadata and sent it a redirect.
- Integration with fproxy needs to be cleaned up. i.e. the redirect url
shouldn't be hard coded and query parmeters need to be reconstructed for the
redirect.
- the dbr date override query argument isn't supported yet.
- it doesn't set caching headers like fproxy yet.
- non FEC SplitFile downloads are not supported. Since non-redundant
Splitfiles almost never work, this isn't a very high priority for me.
- the skip local data store option isn't implemented.
Known Bugs:
Canceling sometimes doesn't work. I am looking into this. It looks
like AutoRequester is swallowing InterruptedExceptions...
I would like to hand off the open issues except for the canceling bug
and the local data store skipping to Matthew and concentrate on
getting SplitFile insert support into AutoRequester. Of course I will
also work on fixing any bugs found in the new SplitFile downloading
code.
What do you think?
I don't have that much spare programming time. I'm afraid that if I try to
do all of it myself, I will end up slowing down the next point
release.
I'll try to catch up with you on IRC in the next couple of days.
--gj
_______________________________________________
devl mailing list
devl at freenetproject.org
http://hawk.freenetproject.org/cgi-bin/mailman/listinfo/devl
