There was a bug in FproxyServlet.java that caused the build to fail.
I've attached a patch, but it's really only one line.

On line 492 change 

(search for indexOf(\"MSIE\ \"), and recompile.</p>");

to 

(search for indexOf(\"MSIE\"), and recompile.</p>");


-- 
Current soundtrack @ 09/07/02 00:11 'Bob Dylan - Biograph (Disc 2) - 16
- Isis'
Freenet Ref: http://danky.com/groovy.danky.com.ref
PGP Key:     http://danky.com/keys/danello.pgp
-------------- next part --------------
--- FproxyServlet.old   Fri Sep  6 23:24:40 2002
+++ FproxyServlet.java  Fri Sep  6 23:30:35 2002
@@ -492,7 +492,7 @@
             PrintWriter pw = resp.getWriter();
             pw.println("<html><head><title>Internet Explorer Allows Sites To 
Compromize Your Anonymity</title></head>");
             pw.println("<body bgcolor=\"#ffffff\"><h1>Internet Explorer Allows 
Sites To Compromize Your Anonymity</h1>");
-            pw.println("<p>Microsoft Internet Explorer (all versions, as far 
as we know, and this is not likely to be fixed) does not respect MIME types. 
This means it is impossible for fproxy to protect your anonymity on freenet. 
There may be bugs etc. in fproxy's filter that make other browsers unsafe, but 
IE's behaviour makes it more or less impossible to filter out content that 
might make your browser do something to compromize your anonymity (scripting, 
and talking to internet servers outside of freenet). This is not a theoretical 
risk, it is a practical one - just insert your HTML as text/plain, and it will 
pass straight through the content filter without being checked for web-bugs or 
javascript. \"Fixing\" this would require filtering text/plain, and possibly 
all mime types, as well as text/html and text/css, and abandoning any 
possibility of rewriting the filter to only let through content that it 
understands (in order to prevent future standards/extensions to HTML bypassing 
the content filter). This does not necessarily mean that IE is insecure as a 
web browser in general, it just means that it is incompatible with freenet's 
anonymity filter. To disable this message permanently, edit the file 
FproxyServlet.java in the freenet source (search for indexOf(\"MSIE\ \"), and 
recompile.</p>");
+            pw.println("<p>Microsoft Internet Explorer (all versions, as far 
as we know, and this is not likely to be fixed) does not respect MIME types. 
This means it is impossible for fproxy to protect your anonymity on freenet. 
There may be bugs etc. in fproxy's filter that make other browsers unsafe, but 
IE's behaviour makes it more or less impossible to filter out content that 
might make your browser do something to compromize your anonymity (scripting, 
and talking to internet servers outside of freenet). This is not a theoretical 
risk, it is a practical one - just insert your HTML as text/plain, and it will 
pass straight through the content filter without being checked for web-bugs or 
javascript. \"Fixing\" this would require filtering text/plain, and possibly 
all mime types, as well as text/html and text/css, and abandoning any 
possibility of rewriting the filter to only let through content that it 
understands (in order to prevent future standards/extensions to HTML bypassing 
the content filter). This does not necessarily mean that IE is insecure as a 
web browser in general, it just means that it is incompatible with freenet's 
anonymity filter. To disable this message permanently, edit the file 
FproxyServlet.java in the freenet source (search for indexOf(\"MSIE\"), and 
recompile.</p>");
             pw.println("<p>There are many other web browsers out there, such 
as <a href=\"http://www.mozilla.org\";>Mozilla</a> (Windows, Linux, MacOS, most 
things, off-freenet link), and <a href=\"http://www.kde.org/\";>Konqueror</a> 
(linux only, off-freenet link), which are free.<hr>");
             if (badBrowserWarningsSentTo.size() < maxBadBrowserIPs) {
               pw.println("If you are really really sure you want to proceed, 
don't say we didn't warn you, and click <a href=\"" + req.getRequestURI() +
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 882 bytes
Desc: not available
URL: 
<https://emu.freenetproject.org/pipermail/devl/attachments/20020907/d818b973/attachment.pgp>

Reply via email to