> I haven't seen this happen locally, so I don't have any ideas. The
> installer shouldn't be messing up like that though - afaik, it's not
> a common occurance.
>
> The only real way to make it better in this respect, imho, would be to
> generate the installer a new way which allows for easier use of external
> configuration program (meaning not nsis).

I've found the problem, heh, it's kind of amusing because it reinforces my
lack of faith in the Nullsoft Installer System.  I will spend a bit of time
reading through Microsoft's Installer Development Kit and try and migrate
the current Freenet installer to that over the next few weeks (have a bit of
time on my hands having just been made redundant :-(

> If it's reproducable in a new directory, I'd like information (like the
> install.log)

It's reproducible if you install Freenet into a directory which is a
SUBdirectory of a previous installation of freenet.  So, it's a new
directory but not a brand-new root directory tree.
The reason seems to be, amusingly, that NSIS will interpret
Exec: command=""H:\Freenet\freenet5\Freenet 0.5\cfgnode.exe"
freenet.ini --silent"
as
Exec: command=""H:\Freenet\freenet5\Freenet.exe" 0.5\cfgnode.exe
freenet.ini --silent"
if the file H:\Freenet\freenet5\Freenet.exe exists.  I thought Windoze
developers worked out how to cope with spaces in filenames around about
1995, seems Justin Frankel has some catching up to do ...

If it's possible and easy to 'shortify' an executable file+path from within
NSIS then I recommend that this is done prior to each exec command.  This is
from my experience with WISE Installer which imho is just as awful.
H:\Freenet\Freenet5\Freene~1\cfgnode.exe is unambiguous and there's a Win32
API mapping between long filenames (contain spaces) and short (don't).
If it's not possible (either NSIS doesn't have short/long support built in
or there's no way to execute Win32 API calls from within NSIS) then we
simply must use a different installer system as this is unjustifiably bad
and WILL affect users intermittently (there should be no reason to ever
force a user to limit where they install Freenet to a subset of valid
directories).

d


_______________________________________________
devl mailing list
devl at freenetproject.org
http://hawk.freenetproject.org/cgi-bin/mailman/listinfo/devl

Reply via email to