* Matthew Toseland <toad at amphibian.dyndns.org> [2006-07-29 16:15:41]:

> A valid packet usually being an ack for a keepalive. Okay. Would you
> like to fix that?

I would prefer you to do it... I'm focusing on something else atm. 

NextGen$
> 
> On Sat, Jul 29, 2006 at 04:27:03PM +0200, Florent Daigni?re (NextGen$) wrote:
> > * Matthew Toseland <toad at amphibian.dyndns.org> [2006-07-26 00:58:46]:
> > 
> > > Well the packet isn't being received. What do you think is the best way
> > > forward? One option is to track when we last received a valid packet
> > > rather than a message, and use that in the case of non-routable nodes?
> > 
> > Yes, that's probably the best solution ...
> > 
> > NextGen$
> > > 
> > > On Wed, Jul 26, 2006 at 01:15:17AM +0200, Florent Daigni?re (NextGen$) 
> > > wrote:
> > > > * toad at freenetproject.org <toad at freenetproject.org> [2006-07-25 
> > > > 20:45:50]:
> > > > 
> > > > > Author: toad
> > > > > Date: 2006-07-25 20:45:49 +0000 (Tue, 25 Jul 2006)
> > > > > New Revision: 9763
> > > > > 
> > > > > Modified:
> > > > >    trunk/freenet/src/freenet/node/PacketSender.java
> > > > > Log:
> > > > > don't disconnect from idle, incompatible nodes
> > > > > 
> > > > > Modified: trunk/freenet/src/freenet/node/PacketSender.java
> > > > > ===================================================================
> > > > > --- trunk/freenet/src/freenet/node/PacketSender.java  2006-07-25 
> > > > > 20:39:02 UTC (rev 9762)
> > > > > +++ trunk/freenet/src/freenet/node/PacketSender.java  2006-07-25 
> > > > > 20:45:49 UTC (rev 9763)
> > > > > @@ -162,7 +162,7 @@
> > > > >               }
> > > > >               
> > > > >                  // Is the node dead?
> > > > > -                if(now - pn.lastReceivedPacketTime() > 
> > > > > pn.maxTimeBetweenReceivedPackets()) {
> > > > > +                if(pn.isRoutable() && now - 
> > > > > pn.lastReceivedPacketTime() > pn.maxTimeBetweenReceivedPackets()) {
> > > > >                       Logger.normal(this, "Disconnecting from "+pn+" 
> > > > > - haven't received packets recently");
> > > > >                      pn.disconnected();
> > > > >                      continue;
> > > > > 
> > > > 
> > > > When are we disconnecting from disconnected non-routable nodes then ?
> > > > isn't LinkPingPong sending a packet each time ?
> > > > 
> > > > NextGen$
> > > 
> > > 
> > > 
> > > > _______________________________________________
> > > > Devl mailing list
> > > > Devl at freenetproject.org
> > > > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
> > > 
> > > -- 
> > > Matthew J Toseland - toad at amphibian.dyndns.org
> > > Freenet Project Official Codemonkey - http://freenetproject.org/
> > > ICTHUS - Nothing is impossible. Our Boss says so.
> > 
> > 
> 
> 
> 
> -- 
> Matthew J Toseland - toad at amphibian.dyndns.org
> Freenet Project Official Codemonkey - http://freenetproject.org/
> ICTHUS - Nothing is impossible. Our Boss says so.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL: 
<https://emu.freenetproject.org/pipermail/devl/attachments/20060729/dc66f1f3/attachment.pgp>

Reply via email to