IMHO we should allow DDA's to have an Identifier, which if not specified is 
the directory name given. Then we can easily implement #1753.

On Friday 30 November 2007 23:44, you wrote:
> Author: nextgens
> Date: 2007-11-30 23:44:06 +0000 (Fri, 30 Nov 2007)
> New Revision: 16168
> 
> Modified:
>    trunk/freenet/src/freenet/node/fcp/FCPConnectionHandler.java
> Log:
> Resolve #1856: Nested TestDDA fails
> 
> Modified: trunk/freenet/src/freenet/node/fcp/FCPConnectionHandler.java
> ===================================================================
> --- trunk/freenet/src/freenet/node/fcp/FCPConnectionHandler.java      
> 2007-11-30 
23:34:04 UTC (rev 16167)
> +++ trunk/freenet/src/freenet/node/fcp/FCPConnectionHandler.java      
> 2007-11-30 
23:44:06 UTC (rev 16168)
> @@ -372,8 +372,15 @@
>               if(!directory.exists() || !directory.isDirectory())
>                       throw new IllegalArgumentException("The specified path 
> isn't a 
directory! or doesn't exist or the node doesn't have access to it!");
>               
> +             // See #1856
> +             DDACheckJob job = null;
> +             synchronized (inTestDirectories) {
> +                     job = (DDACheckJob) inTestDirectories.get(directory);
> +             }
> +             if(job != null)
> +                     throw new IllegalArgumentException("There is already a 
> TestDDA going on 
for that directory!");
> +             
>               File writeFile = (write ? new File(path, "DDACheck-" + new 
Random().nextInt() + ".tmp") : null);
> -             
>               File readFile = null;
>               if(read) {
>                       try {
> 
> _______________________________________________
> cvs mailing list
> cvs at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> 
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL: 
<https://emu.freenetproject.org/pipermail/devl/attachments/20071201/f1c714d0/attachment.pgp>

Reply via email to