* Matthew Toseland <toad at amphibian.dyndns.org> [2007-12-18 15:19:59]:
> I don't get it.
I don't get what you don't get :)
What it was doing was :
1) take the mutex
2) test if fecRunnerThread is null
3) if so, *re*test if it's not (always false)
4) then log something...
What it should do is :
1) take the mutex
2) test if fecRunnerThread is null
3) if it's not, log something
>
> On Monday 17 December 2007 00:24, you wrote:
> > Author: nextgens
> > Date: 2007-12-17 00:24:38 +0000 (Mon, 17 Dec 2007)
> > New Revision: 16638
> >
> > Modified:
> > trunk/freenet/src/freenet/client/FECCodec.java
> > Log:
> > FECCodec: fix the logic
> >
> > Modified: trunk/freenet/src/freenet/client/FECCodec.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/client/FECCodec.java 2007-12-17 00:23:06 UTC
> (rev 16637)
> > +++ trunk/freenet/src/freenet/client/FECCodec.java 2007-12-17 00:24:38 UTC
> (rev 16638)
> > @@ -323,14 +323,13 @@
> > public static void addToQueue(FECJob job, FECCodec codec) {
> > synchronized(_awaitingJobs) {
> > if(fecRunnerThread == null) {
> > - if(fecRunnerThread != null)
> > - Logger.error(FECCodec.class, "The
> > callback died!! restarting a new
> one, please report that error.");
> > fecRunnerThread = new Thread(fecRunner, "FEC
> > Pool " +
> (fecPoolCounter++));
> > fecRunnerThread.setDaemon(true);
> >
> > fecRunnerThread.setPriority(Thread.MIN_PRIORITY);
> >
> > fecRunnerThread.start();
> > - }
> > + }else
> > + Logger.error(FECCodec.class, "The callback
> > died!! restarting a new one,
> please report that error.");
> >
> > _awaitingJobs.addFirst(job);
> > }
> >
> > _______________________________________________
> > cvs mailing list
> > cvs at freenetproject.org
> > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> >
> >
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 189 bytes
Desc: Digital signature
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20071218/69dbcdcd/attachment.pgp>
