> > That I have seen, it's some kind of bug. Are you sure it's not caused by > > your recent changes? The request does get cancelled?
Just found an old open bug describing the same. So this was definetly not caused by my changes. But as my change prevents further messages after the request was removed (to suppress more Failed messages during kill of request) we most likely will NOT see this bug any longer BUT it is still there, i.e. the phantom insert still continues to run. This should be solved sometimes. I update the bug with this text. https://bugs.freenetproject.org/view.php?id=608 On 2/14/07, bbackde at googlemail.com <bbackde at googlemail.com> wrote: > Tese issues were fixed when you wrote this mail, you missing my follow > up mail? A layout like googlemail provides for mails helps alot to > keep up to date with all recent follow ups ;) > > imho the code is finished, you could review it and maybe release it. > > On 2/14/07, Matthew Toseland <toad at amphibian.dyndns.org> wrote: > > On Mon, Feb 12, 2007 at 06:58:52PM +0100, bbackde at googlemail.com wrote: > > > If I run 2 FCP2 clients (frost) then I see PRModified and PRRemoved > > > messages if the other client changes the global queue. But if I change > > > the priority in fproxy, or remove the request in fproxy, no message is > > > sent to the clients. How does fproxy access the global queue, some > > > special path??? > > > > It shouldn't... FCPServer.removeGlobalRequest, fcp.getGlobalRequests() > > and then call functions on them etc. Maybe these should be wrapped > > better for proper internal use. It's all called from > > QueueToadlet.handlePost, have a look at it. > > > > > > Another observation: I added a new upload request into the global > > > queue using frost. Then I removed the request using fproxy. No > > > PRRemoved was sent, but after next ListPR from Frost the request > > > disappeared. But then the node started to send SimpleProgress messages > > > for the removed requests, it looks like the request wasn't really > > > deleted. Did it continue to run in the background? No client > > > (including fproxy) showed the request. > > > > That I have seen, it's some kind of bug. Are you sure it's not caused by > > your recent changes? The request does get cancelled? > > > > > > This was with the latest SVN code... > > > > -----BEGIN PGP SIGNATURE----- > > Version: GnuPG v1.4.6 (GNU/Linux) > > > > iD8DBQFF0mjQA9rUluQ9pFARAkeEAJ0cGNDYZMmccNmx1wSq9ATmaI3TCwCglISq > > utlwYumsz/vIsMlqeuEDqSU= > > =AOVh > > -----END PGP SIGNATURE----- > > > > _______________________________________________ > > Devl mailing list > > Devl at freenetproject.org > > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl > > >
