On Wednesday 28 November 2007 15:20, Florent Daigni?re wrote:
> * Matthew Toseland <toad at amphibian.dyndns.org> [2007-11-28 14:20:49]:
>
> > There was a reason for that. We need File's pointing to temp bucket file's
to
> > be comparable. So it needs to be canonical. Of course, that means we can
keep
> > a separate File for the original if we need it for config purposes...
>
> Previously it was absolute and now it's canonical, so what's the problem
> ? I don't get it :$
Do we canonicalise it anywhere? We used to have leaks because of the files not
being equal due to not being absolute.
>
> >
> > On Thursday 22 November 2007 16:23, you wrote:
> > > Author: nextgens
> > > Date: 2007-11-22 16:23:14 +0000 (Thu, 22 Nov 2007)
> > > New Revision: 15925
> > >
> > > Modified:
> > > trunk/freenet/src/freenet/support/io/PersistentTempBucketFactory.java
> > > Log:
> > > Fix #1886: absolute path prepended to persistent temp location
> > >
> > > Modified:
> > trunk/freenet/src/freenet/support/io/PersistentTempBucketFactory.java
> > > ===================================================================
> > > ---
trunk/freenet/src/freenet/support/io/PersistentTempBucketFactory.java
> > 2007-11-22 15:56:20 UTC (rev 15924)
> > > +++
trunk/freenet/src/freenet/support/io/PersistentTempBucketFactory.java
> > 2007-11-22 16:23:14 UTC (rev 15925)
> > > @@ -42,7 +42,7 @@
> > >
> > > public PersistentTempBucketFactory(File dir, String prefix,
RandomSource
> > rand) throws IOException {
> > > boolean logMINOR = Logger.shouldLog(Logger.MINOR, this);
> > > - this.dir = dir.getAbsoluteFile();
> > > + this.dir = dir;
> > > this.rand = rand;
> > > this.fg = new FilenameGenerator(rand, false, dir, prefix);
> > > if(!dir.exists()) {
> > >
> > > _______________________________________________
> > > cvs mailing list
> > > cvs at freenetproject.org
> > > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> > >
> > >
>
>
>
> > _______________________________________________
> > Devl mailing list
> > Devl at freenetproject.org
> > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20071128/794f66ba/attachment.pgp>
