We need better handling of this sort of option ... at the very least, the node
should accept the change, write it to disk, and then tell the user that they
need to restart their node, with a button to do so. There has been a bug
filed for this since very early on... probably all we need is a custom
exception, handling for it in the config toadlet and the FCP code, and some
changes in the callbacks...
On Sunday 10 August 2008 12:32, j16sdiz at freenetproject.org wrote:
> Author: j16sdiz
> Date: 2008-08-10 11:32:45 +0000 (Sun, 10 Aug 2008)
> New Revision: 21704
>
> Modified:
>
branches/saltedhashstore/freenet/src/freenet/l10n/freenet.l10n.en.properties
> branches/saltedhashstore/freenet/src/freenet/node/Node.java
> Log:
> Allow changing datastore type from ConfigToadlet
>
> Modified:
branches/saltedhashstore/freenet/src/freenet/l10n/freenet.l10n.en.properties
> ===================================================================
> ---
branches/saltedhashstore/freenet/src/freenet/l10n/freenet.l10n.en.properties
2008-08-10 11:14:09 UTC (rev 21703)
> +++
branches/saltedhashstore/freenet/src/freenet/l10n/freenet.l10n.en.properties
2008-08-10 11:32:45 UTC (rev 21704)
> @@ -705,7 +705,7 @@
> Node.storeSize=Store size in bytes
> Node.storeSizeLong=Store size in bytes
> Node.storeType=Store type (LEAVE THIS ALONE)
> -Node.storeTypeLong=Datastore type. Currently this can be bdb-index (use a
BerkeleyDBFreenetStore to store the index, and keep the data in files on
disk), or ram (keep the index and the data in RAM). Only use ram if you know
what you are doing and have enough RAM to store all your data (and note it
will not be saved on shutdown)!
> +Node.storeTypeLong=Datastore type. Currently this can be salt-hash (use a
salted on-disk hashtable with bloom filter), bdb-index (use a
BerkeleyDBFreenetStore to store the index, and keep the data in files on
disk), or ram (keep the index and the data in RAM). Only use ram if you know
what you are doing and have enough RAM to store all your data (and note it
will not be saved on shutdown)! Changes will not take effect until Freenet
has been restarted.
> Node.swapRInterval=Swap request send interval (ms)
> Node.swapRIntervalLong=Interval between swap attempting to send swap
requests in milliseconds. Leave this alone!
> Node.throttleLocalTraffic=Throttle local traffic?
>
> Modified: branches/saltedhashstore/freenet/src/freenet/node/Node.java
> ===================================================================
> --- branches/saltedhashstore/freenet/src/freenet/node/Node.java
> 2008-08-10
11:14:09 UTC (rev 21703)
> +++ branches/saltedhashstore/freenet/src/freenet/node/Node.java
> 2008-08-10
11:32:45 UTC (rev 21704)
> @@ -178,7 +178,8 @@
> }
>
> public void set(String val) throws InvalidConfigValueException {
> - throw new InvalidConfigValueException("Store type
> cannot be changed on
the fly");
> + // need restart to effect
> + config.get("node").set("storeType", val);
> }
>
> public String[] getPossibleValues() {
>
> _______________________________________________
> cvs mailing list
> cvs at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20080812/b048f6cc/attachment.pgp>
