On Wednesday 13 August 2008 14:04, Ian Clarke wrote: > On Wed, Aug 13, 2008 at 7:25 AM, Matthew Toseland > <toad at amphibian.dyndns.org> wrote: > > On Wednesday 13 August 2008 13:06, Ian Clarke wrote: > >> So I've given up on getting people to use CodeCollaborator, but > >> fortunately Google Code now has a free code review tool that perhaps > >> people will want to try - it has *got* to be better than the current > >> approach of reading through and replying to diff emails manually. > > > > Why? It's just one more point of failure, isn't it? > > Yeah, Google is really likely to fail. > > > And almost everyone subscribes to the mailing list. > > That doesn't mean that everyone finds it easy to trawl through > comments interspersed with file diffs. I know change is traumatic, > but anything we can do to make it easier for people to participate in > development is a good thing. Can you at least try it?
Mailing lists work well for our review process, which is opportunistic review (except for myself and to some degree nextgens). Once an issue has been raised, everyone, including and especially those who aren't part of the regular code review process, can see what the issue is. This is the opposite of CodeCollaborator: it is designed for a formal review process where a group of people are pre-selected to review every commit. It does not work well when most of your coders are volunteers who do not have the time to review everything. At least that was my impression. Is it totally misguided? > > Ian. -------------- next part -------------- A non-text attachment was scrubbed... Name: not available Type: application/pgp-signature Size: 189 bytes Desc: not available URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20080814/5d1d224f/attachment.pgp>
