* Dave Baker <dbkr at freenetproject.org> [2008-08-09 23:43:54]: > Hi, > > I've just had to apply the attached patch to Freenet in order to be able > to connect to FProxy or the FCP server on a standard OS X box. I don't > suggest applying this patch: this is almost certainly not how it's meant > to work, but I'm thoroughly confused by all of this code... > > Firstly, what's the necessity for the flag to enable the scope matching? > The address string converter method puts a scope on, and since the flag > wasn't turned on in this case, it wasn't matching the address and so it > was getting rejected. Why we ever not want to match addresses with > scopes? >
We got rid of the code which was requiering it a while ago... it's leftovers, you can simplify it :) > Secondly, why is all this address matching necessary? The code in > question starts off with an address object, converts it to bytes, > converts that to a string, then matches the string against a regex to > determine the address type. Why would just doing an instanceof not > suffice here? > We need to be able to identify ISATAP addresses... because of Vista; As far as I know the java API doesn't provide any method to do it. > There's more that seems to me to be done unnecessarily inefficiently, > but I'll stay on topic and leave it at that for now. Send a patch :) -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 197 bytes Desc: Digital signature URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20080815/d3e48135/attachment.pgp>
