On Fri, Aug 22, 2008 at 5:47 PM, Florent Daigni?re
<nextgens at freenetproject.org> wrote:
> * j16sdiz at freenetproject.org <j16sdiz at freenetproject.org> [2008-08-22
> 08:38:19]:
>
>> Author: j16sdiz
>> Date: 2008-08-22 08:38:18 +0000 (Fri, 22 Aug 2008)
>> New Revision: 22086
>>
>> Modified:
>> trunk/freenet/src/freenet/client/async/SimpleManifestPutter.java
>> Log:
>> fix possible NPE
>>
>> Modified: trunk/freenet/src/freenet/client/async/SimpleManifestPutter.java
>> ===================================================================
>> --- trunk/freenet/src/freenet/client/async/SimpleManifestPutter.java
>> 2008-08-22 08:37:58 UTC (rev 22085)
>> +++ trunk/freenet/src/freenet/client/async/SimpleManifestPutter.java
>> 2008-08-22 08:38:18 UTC (rev 22086)
>> @@ -68,7 +68,8 @@
>> private final Bucket data;
>>
>> public void start() throws InsertException {
>> - if((origSFI == null) && (metadata != null)) return;
>> + if ((origSFI == null) || (metadata != null))
>> + return;
>> origSFI.start(null);
>> origSFI = null;
>> }
>
> Log or throw something here... we don't want to silently ignore.
fixed at r22096
