On Tue, Dec 9, 2008 at 10:31 PM, Matthew Toseland
<toad at amphibian.dyndns.org> wrote:
> On Monday 08 December 2008 13:42, j16sdiz at freenetproject.org wrote:
>> Author: j16sdiz
>> Date: 2008-12-08 13:42:35 +0000 (Mon, 08 Dec 2008)
>> New Revision: 24129
>>
>> Modified:
>> trunk/plugins/XMLSpider/XMLSpider.java
>> Log:
>> comment invalid code
>>
>> Modified: trunk/plugins/XMLSpider/XMLSpider.java
>> ===================================================================
>> --- trunk/plugins/XMLSpider/XMLSpider.java 2008-12-08 13:36:06 UTC (rev
> 24128)
>> +++ trunk/plugins/XMLSpider/XMLSpider.java 2008-12-08 13:42:35 UTC (rev
> 24129)
>> @@ -1323,8 +1323,14 @@
>>
>> public void onFoundEdition(long l, USK key){
>> FreenetURI uri = key.getURI();
>> + /*-
>> + * FIXME this code don't make sense
>> + * (1) runningFetchesByURI contain SSK, not USK
>> + * (2) onFoundEdition always have the edition set
>> + *
>> if(runningFetchesByURI.containsKey(uri))
>> runningFetchesByURI.remove(uri);
>> uri = key.getURI().setSuggestedEdition(l);
>
> Ok so the answer is to call getSSK(edition) rather than
> getURI().setSuggestedEdition(edition). Just queueing the USK is wrong.
queueURI() would convert it to SSK.
The reason why i commented this is:
(1) .setSuggestedEdition() is not necessary -- it's already set.
(2) runningFetchesByURI.containsKey() always return false
-- it won't contain any USK.
>> + */
>> queueURI(uri);
>> }
>
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
