On Sunday 14 December 2008 13:12, xor at freenetproject.org wrote:
> Author: xor
> Date: 2008-12-14 13:12:37 +0000 (Sun, 14 Dec 2008)
> New Revision: 24308
>
> Modified:
> trunk/plugins/MDNSDiscovery/javax/jmdns/JmDNS.java
> Log:
> Add FIXME.
>
> Modified: trunk/plugins/MDNSDiscovery/javax/jmdns/JmDNS.java
> ===================================================================
> --- trunk/plugins/MDNSDiscovery/javax/jmdns/JmDNS.java 2008-12-14
> 13:03:38
UTC (rev 24307)
> +++ trunk/plugins/MDNSDiscovery/javax/jmdns/JmDNS.java 2008-12-14
> 13:12:37
UTC (rev 24308)
> @@ -290,6 +290,8 @@
> socket.close();
> if (incomingListener != null)
> {
> + /* FIXME: This is probably not the proper way to
> shutdown.
toad/nextgens said that threads are recycled so join is bad.
> + * Use notify()/wait() and a boolean instead. See
freenet.support.TransferThread for an example. */
> incomingListener.join();
Only if MDNS uses our executor which I find highly unlikely. IIRC it creates
its own threads, doesn't it? Or is incomingListener the one thread created
directly by the parent? Maybe threaded plugins should be run directly on
threads ...
> }
> }
>
> _______________________________________________
> cvs mailing list
> cvs at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20081216/d80ea93b/attachment.pgp>
