On Tue, Dec 30, 2008 at 10:19 AM,  <juiceman at freenetproject.org> wrote:
> Author: juiceman
> Date: 2008-12-30 02:19:05 +0000 (Tue, 30 Dec 2008)
> New Revision: 24835
>
> Modified:
>   trunk/freenet/src/freenet/support/BloomFilter.java
> Log:
> FindBugs says: "This finalizer nulls out fields. This is usually an error, as 
> it does not aid garbage collection, and the object is going to be garbage 
> collected anyway."

This is _NOT_ an error.
If you look at a few lines above, it use filter as a flag.

>
> Modified: trunk/freenet/src/freenet/support/BloomFilter.java
> ===================================================================
> --- trunk/freenet/src/freenet/support/BloomFilter.java  2008-12-30 02:01:38 
> UTC (rev 24834)
> +++ trunk/freenet/src/freenet/support/BloomFilter.java  2008-12-30 02:19:05 
> UTC (rev 24835)
> @@ -195,7 +195,5 @@
>                if (filter != null) {
>                        force();
>                }
> -               filter = null;
> -               forkedFilter = null;
>        }
>  }
>
> _______________________________________________
> cvs mailing list
> cvs at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
>

Reply via email to