On Sunday 25 May 2008 12:42, Daniel Cheng wrote:
> On Sat, May 24, 2008 at 2:33 AM, Matthew Toseland
> <toad at amphibian.dyndns.org> wrote:
> > On Thursday 22 May 2008 11:31, j16sdiz at freenetproject.org wrote:
> >> Author: j16sdiz
> >> Date: 2008-05-22 10:31:44 +0000 (Thu, 22 May 2008)
> >> New Revision: 20027
> >>
> >> Modified:
> >>
> >
branches/saltedhashstore/freenet/src/freenet/store/SaltedHashFreenetStore.java
> >> Log:
> >> Limit oldItems file size
> >>
> >>
> >> Modified:
> >
branches/saltedhashstore/freenet/src/freenet/store/SaltedHashFreenetStore.java
> >> ===================================================================
> >> ---
> >
branches/saltedhashstore/freenet/src/freenet/store/SaltedHashFreenetStore.java
> > 2008-05-22 10:24:30 UTC (rev 20026)
> >> +++
> >
branches/saltedhashstore/freenet/src/freenet/store/SaltedHashFreenetStore.java
> > 2008-05-22 10:31:44 UTC (rev 20027)
> >> @@ -976,7 +976,7 @@
> >> }
> >> }
> >>
> >> - if (queueItem) {
> >> + if (queueItem &&
oldItemsFC.position() < 0x10000000) { // Limit to
> > 256MiB
> >
> > Wouldn't it be better to make it some fixed fraction of the total size or
> > perhaps of the limit?
>
> sure.
> but then we have to ask: what is the right limit?
>
> I am not going to tune these kind of stuff at this stage.
5%? I suppose it would have to be configurable...
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20080527/d71b38bd/attachment.pgp>
