I don't get this either. Should we revert it? AFAICS combined with my later
commit, this only loads plugins from disk if the uri is an absolute filename?
(Actually on windows, a filename with a drive letter may not always be
absolute)??? Why is supporting loading plugins from relative filenames a
problem?
On Friday 28 November 2008 01:08, Daniel Cheng wrote:
> On Fri, Nov 28, 2008 at 6:37 AM, <saces at freenetproject.org> wrote:
> > Author: saces
> > Date: 2008-11-27 22:37:29 +0000 (Thu, 27 Nov 2008)
> > New Revision: 23924
> >
> > Modified:
> > trunk/freenet/src/freenet/pluginmanager/PluginManager.java
> > Log:
> > do not forward a possible local filename to url handler if file not exist
>
> arrr... you are bring back a old bug.
>
> I did this change on r22718 --
> This break the "Reload" button on plugin page for unofficial plugin.
>
> >
> > Modified: trunk/freenet/src/freenet/pluginmanager/PluginManager.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/pluginmanager/PluginManager.java 2008-11-27
22:21:31 UTC (rev 23923)
> > +++ trunk/freenet/src/freenet/pluginmanager/PluginManager.java 2008-11-27
22:37:29 UTC (rev 23924)
> > @@ -214,9 +214,12 @@
> > // not a freenet key
> > }
> >
> > - if(new File(pluginname).exists()) {
> > - startPluginFile(pluginname, store);
> > - return;
> > + File[] roots = File.listRoots();
> > + for(File f : roots) {
> > + if(pluginname.startsWith(f.getName())) {
> > + startPluginFile(pluginname, store);
> > + return;
> > + }
> > }
> >
> > startPluginURL(pluginname, store);
> >
> > _______________________________________________
> > cvs mailing list
> > cvs at freenetproject.org
> > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> >
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20081129/88ce548a/attachment.pgp>
