On Friday 19 September 2008 02:56, Daniel Cheng wrote:
> On Sat, Sep 13, 2008 at 1:39 AM, <toad at freenetproject.org> wrote:
> > Author: toad
> > Date: 2008-09-12 17:39:26 +0000 (Fri, 12 Sep 2008)
> > New Revision: 22631
> >
> > Modified:
> > trunk/freenet/src/freenet/node/updater/UpdateOverMandatoryManager.java
> > Log:
> > Possibly fix some updater bugs.
> > Needs testing!
> >
>
> Are there any automated test for revoking update?
> This feature is rarely used/tested.
> When we need this, we have no time/ways to fix it.
I have tested it, but at present there is no automated test. It would be good
to write one, but I'm not planning to in the near future.
>
> >
> > Modified:
trunk/freenet/src/freenet/node/updater/UpdateOverMandatoryManager.java
> > ===================================================================
> > --- trunk/freenet/src/freenet/node/updater/UpdateOverMandatoryManager.java
> >
2008-09-12 17:08:44 UTC (rev 22630)
> > +++ trunk/freenet/src/freenet/node/updater/UpdateOverMandatoryManager.java
> >
2008-09-12 17:39:26 UTC (rev 22631)
> > @@ -273,6 +273,7 @@
> > private void sendUOMRequestMain(final PeerNode source, boolean
addOnFail) {
> > if(logMINOR)
> >
Logger.minor(this, "sendUOMRequestMain("+source+","+addOnFail+")");
> > + if(!source.isConnected()) return;
> > synchronized(this) {
> > long offeredVersion =
source.getMainJarOfferedVersion();
> > if(offeredVersion <
updateManager.newMainJarVersion()) {
> > @@ -365,6 +366,7 @@
> > >=
MAX_NODES_SENDING_MAIN_JAR)
> > return;
> >
if(nodesSendingMainJar.contains(offers[i])) continue;
> > +
if(nodesAskedSendMainJar.contains(offers[i])) continue;
> > }
> > sendUOMRequestMain(offers[i], false);
> > }
> >
> > _______________________________________________
> > cvs mailing list
> > cvs at freenetproject.org
> > http://emu.freenetproject.org/cgi-bin/mailman/listinfo/cvs
> >
> _______________________________________________
> Devl mailing list
> Devl at freenetproject.org
> http://emu.freenetproject.org/cgi-bin/mailman/listinfo/devl
>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20080919/2e6ac280/attachment.pgp>
