On Sunday 05 July 2009 14:25:07 Mario Volke wrote: > Hello, > > over the last weeks I've developed a plugin for Freenet called Freereader. > In simple words, it's a newsfeed importer for Freenet. > I temporarily uploaded a documentation file under > http://www.webholics.de/freereader/docs > The plugin jar file is available (also only temporarily) under > http://www.webholics.de/freereader/Freereader.jar > > Now the question for me is how the next steps could look like. > Could I contribute the source to the Freenet repo and could s.o. publish > the plugin over the freenet website? > General Feedback is also very welcome. > > I think the plugin could do a good job with importing high quality and > useful content to Freenet. > > Regards, > Mario
I apologise for taking so long to get around to this and hope that you will get back to working with Freenet at some point. I have reviewed the code, fixed up incompatibilities with current fred, removed the jars and updated the build process. It seems to work, and the code is nice and clean. Note to anyone watching: I had to use git-filter-branch to remove the old jars. This massively reduces the size of the repo and dumps a lot of unnecessary cruft, however it involves a non-fast-forward update, don't do this on any freenet repo without prior consultation as it makes history very hard to follow for other people! I have pushed the Freereader plugin and added it to the official plugins list, so as of next build anyone can obtain Freereader from the plugins page. Code review follows: Freereader: - Uses a db4o database. Should encrypt it or use ours (which would require changing various things, and might have classloader issues??). This is a common problem with all database-based plugins (notably WoT). - UpdateTask.run usage of running - finally block needed? - Should remember what edition it uses - it probably already does, but it should pass it in the USK to speed things up. - When do we commit the database? We lock it, so presumably we should commit it before unlocking? - Feeds: db.configure.updateDepth(2); db.store(); - don't do this, do store(this, 2); - ConfigPage: more checking would be nice, e.g. ,200 means if it's over this return "" (or was it null?). Maybe we should throw in this case instead of returning empty? - You should check for the formPassword in POSTs. - Feeds can have identical title, so your compare function should go by url after title. - Proxy support (i.e. fetching feeds over Tor) would be nice. - On the remove form you should link to the feeds. - "Create and upload freesite" does not immediately show RUNNING due to a race condition, should it? - Is http://exslt.org/dates-and-times cached? Or will it pull it in at least on the first usage of Freereader? - L10n is needed. This is another common problem for plugins. I thought we passed menu item names through l10n? - I reloaded the plugin and my database disappeared? -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 835 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20090827/251a6809/attachment.pgp>
