On Wednesday 07 January 2009 00:43, Daniel Cheng wrote:
> On Wed, Jan 7, 2009 at 7:17 AM, <toad at freenetproject.org> wrote:
> > Author: toad
> > Date: 2009-01-06 23:17:19 +0000 (Tue, 06 Jan 2009)
> > New Revision: 24946
> >
> > Modified:
> >
trunk/freenet/src/freenet/clients/http/filter/GenericReadFilterCallback.java
> > Log:
> > Doh
> >
> >
> > Modified:
trunk/freenet/src/freenet/clients/http/filter/GenericReadFilterCallback.java
> > ===================================================================
> > ---
trunk/freenet/src/freenet/clients/http/filter/GenericReadFilterCallback.java
2009-01-06 21:55:28 UTC (rev 24945)
> > +++
trunk/freenet/src/freenet/clients/http/filter/GenericReadFilterCallback.java
2009-01-06 23:17:19 UTC (rev 24946)
> > @@ -252,7 +252,7 @@
> > }
> > if(u.getFragment() != null) {
> > sb.append('#');
> > -
sb.append(freenet.support.URLEncoder.encode(u.getRawFragment(), false));
> > +
sb.append(freenet.support.URLEncoder.encode(u.getFragment(), false));
>
>
> why not just use getRawFragment() ?
>
> the javadoc say it is encoded and never contain illegal characters:
>
> The .... getRawFragment.... methods return the values ... The strings
> returned by these methods may contain both escaped octets and other
> characters, and will not contain any illegal characters.
Even if there were e.g. unencoded octets in the original?
>
> > }
> >
> > URI uri = new URI(sb.toString());
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 827 bytes
Desc: not available
URL:
<https://emu.freenetproject.org/pipermail/devl/attachments/20090107/b5e54229/attachment.pgp>
