On Tuesday 21 December 2010 23:18:50 Martin Nyhus wrote: > On Tuesday 21. December 2010 20:26:11 Matthew Toseland wrote: > > Zidel, what's left in your view? > > At the moment I'm not using the first bit of the sequence number for some > reason (that I can't remember).
Worth checking but not critical. > There is also the problem of message ids > wrapping within the watchlist window, but I don't think it can happen with > the > current code unless the sender actively makes it happen. Right. Well, if it's not going to happen naturally, it's an exploit, but AFAICS it's not a useful exploit, right? > > I'll try to look through all of your earlier reviews to see if I've forgotten > something, but I think those are the only issues that need to be resolved > before merging. > Thanks! Oh, on crypto, we could go half way: Switch to Rijndael 256 key /128 block (because it's more standard), and CBC (because CFB/PCFB has some vulnerabilities, and because it's more standard), and always pad to a multiple of 16 bytes. Or maybe that's a bad idea since it would mean we can't generate packets of other sizes, short of ciphertext stealing? I guess we should postpone the decision. Filed a bug: https://bugs.freenetproject.org/view.php?id=4638 I am hoping to get this all sorted out as soon as I get back to work after Christmas, probably around the 28th. -------------- next part -------------- A non-text attachment was scrubbed... Name: signature.asc Type: application/pgp-signature Size: 197 bytes Desc: This is a digitally signed message part. URL: <https://emu.freenetproject.org/pipermail/devl/attachments/20101224/94a20416/attachment.pgp>
