The original implementation of renaming dataframe column names to correspond to columns in form data was missing key metrics, grouping and spatial columns. To avoid having the same logic defined in several places, new constants `GROUPING_KEYS` and `SPATIAL_KEYS` were added to `viz.py`, and `get_spatial_columns()` function was moved to `utils`. The redundant `BaseViz.get_metric_label()` method was also removed and references pointed to `utils.get_metric_names()` which contained the same logic.
[ Full content available at: https://github.com/apache/incubator-superset/pull/5686 ] This message was relayed via gitbox.apache.org for [email protected]
