Thanks @mistercrunch > Note that the chart function's signature is actually `function (slice, > payload, setControlValue)`. `setControlValue` is a hook to a Redux action > that allows for the chart to modify controls.
I have revised the proposal above to include how to handle `setControlValue`. > To make this frontend visualization plugin possible, we'll need to figure out > how to get rid of the visualization-specific backend code in viz.py over > time, to make sure that visualizations plugins are fully defined as > Javascript. Agree. Let me move this discussion into another SIP, so this one will be kept small and focus on the front-end chart code clean up. We aim that the first pass of this process is to decouple front-end side of these classic vis into packages and be able to use current APIs to power them (i.e. without modifying viz.py yet). Meanwhile there are other workstreams on defining the common query and data format for explore API v2 that can be used to power multiple visualizations and decide what are the post-transformations in js. [ Full content available at: https://github.com/apache/incubator-superset/issues/5680 ] This message was relayed via gitbox.apache.org for [email protected]
