The `mysqlclient` Python package is not optional when running tests (i.e 
running `tox -e <py_version>`). So AFAICT this will break for everyone who 
wants to run the tests (which it did for me) if they don't have the 
`mysql_config` script.

However, this patch is not the right place for this as this 
`docs/installation.rst` is for the actual installation. I know little about 
Tox, but I can't see where there is a natural place where OS deps are handled 
(which is not surprising). Having a Tox plugin for handling this would be nice. 
Wrapping the whole thing in a script like `./run-tests -e <py_env>` where the 
OS deps can be handled might be an option ?

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/3346 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to