@pnowojski  Ok, you are a gentleman and gave me a lot of good advice. I think 
it's necessary to create a new module for each large version of kafka, but if 
we create a separate module for each sub version of kafka, it does seem a bit 
more. But we did use some kafka non-public APIs, and I don't know if they have 
the possibility to be modified in the sub version. If you don't add a separate 
module for the sub version, you will only be able to use branch decisions like 
if/else in the future.

Are you working in the same place with @aljoscha ? If so, can you discuss this 
issue offline? And I will first refactor the current duplicate test code. Do 
you agree?

[ Full content available at: https://github.com/apache/flink/pull/6577 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to