You need to re-architecture the tests: 
1. ok to introduce testSplit5x6x in TestCommon because ES5 and ES6 split the 
same and not ES2
2. ok to introduce an IT version of this test for the same reason
3. Change ESTestCommon.testSplit5x6x : it should be exactly the same as 
previous ES5Test.testSplit modulo the final keywords you were right to add. And 
UTests in ES5 and ES6 should just call     
elasticsearchIOTestCommon.testSplit5x6x(); not create the index.
4. Change ESTestCommon.testITSplit5x6x: it should be exactly the same as 
previous ES5Test.testSplitVolume module the final keywords you were right to 
add.


[ Full content available at: https://github.com/apache/beam/pull/6211 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to