Your commit message says 
(https://github.com/apache/incubator-netbeans/pull/743/commits):
"Add licenseinfor file with media"

It should say: "[NETBEANS-1074] Module Review web.debug" as the PR does.

The commit message survives for the future, the PR is temporary. In general I 
expect a git commit message:

- first line should hold a short summary of the changes (< 70 characters)
- if a jira issue is referenced, place "[_JIRA-ISSUE_] " before the summary in 
the first line (just as you did in the PR message)
- If there is context information available: Why was the change done, what are 
the consequences, which testing was done, place that as text starting in line 3

This way, even years later others can find the referenced issues, understand 
what you did with a quick glance and get detailed information with a deeper 
look, without guessing from the change itself.

For the license changes this is not that important, but it get important if you 
do subtle changes for example for the java parser, xml handling, editor 
behaviour and so on.

Hope that clears it a bit.

[ Full content available at: 
https://github.com/apache/incubator-netbeans/pull/743 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to