I disagree, and this is of the things that annoys me about callbacks. 

When reading code, it makes most sense that the action occur in the order they 
occur on the page. By putting readLedgerMetadata at the end, you are breaking 
that order. Consider how this would look if instead of taking a promise, 
readLedgerMetadata would return a future (something I've been thinking about 
doing).

[ Full content available at: https://github.com/apache/bookkeeper/pull/1587 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to