> I'll update VerifyLibsAndLicenses to correctly handle GPL for external > binaries, that are compile-time only - give me a few days to do that.
Thanks a lot! > For the performance.php: It would be great if you could see if using a > different file is possible. I had a quick(!) look at the SMF sources and > there is /Sources/Subs.php in SMF 2.0.15. That are > 4000 lines of PHP code. > That file would be IMHO better, because it is pure BSD: I also looked at it, but I think its size is small against current performance.php(30972 lines, 837 KB) yet. Instead, we should use [nette.min.php](https://github.com/apache/incubator-netbeans/blob/fa0fe898d43e566e78ab60e9da9909631657a15e/php.editor/test/unit/data/testfiles/actions/testImportData/libs/nette.min.php)(New BSD: 22475 lines, 537 KB) or [Mpdf file](https://github.com/mpdf/mpdf/blob/development/src/Mpdf.php)(GPL: 1.01 MB) which Tomas suggested. @tmysik What do you think? If Mpdf file is better, I'll add it as an external file as well. > I don't quire get what the changes to html*.php are about. We can see "Akismet". Those codes may be part of an external script. So, at least we should not include that word. I found out the similar example code here: https://netbeans.org/bugzilla/show_bug.cgi?id=124273#c0. ```php <body><?php if ($a == 1){ ?> <br/><?php $r =123; ?><br/> <?php } ?> </body> ``` So it should be OK, maybe. Just used `<p></p>` instead of `<br/>`, `echo ""` instead of `$r = 123;`. [ Full content available at: https://github.com/apache/incubator-netbeans/pull/751 ] This message was relayed via gitbox.apache.org for [email protected]
