It seems like line #134 is (and was) obsolete and that this check simply 
ensures one doesn't break. Would it make more sense if one simply removed the 
`break` logic?  According to line #136 (`# FROM clause is over`) one would 
speculate that this portion of the code simply processes a `FROM` clause rather 
than a `JOIN` clause.

[ Full content available at: 
https://github.com/apache/incubator-superset/pull/5703 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to