why remove passing `Singleton` and `class_` while calling `super`? Typo in line 42, should be `SingletonInstance`. line 52 in redundant. The whole `SingletonInstance` class defined in line 42 is redundant. It is not being used anywhere. I think it can be removed.
In fact in this whole speech recognition example, the code around the use of singletons can be refactored. The `Singleton` class defined in line 21 is used only once as a decorator in `label_util.py` module. The `log_util.py` module again defines another class called `SingletonType` which is used to make `LogUtil` class a singleton. There is duplication of code and logic here. [ Full content available at: https://github.com/apache/incubator-mxnet/pull/12291 ] This message was relayed via gitbox.apache.org for [email protected]
