Should we break the `AutoClosable` usage (I know, I'm guilty here) and change 
the interface of `ContainerClient`'s `close` method to be `Future[Unit]`? That 
way, we can make use of akka's asynchronous closing without blocking the thread 
on that operation. Apache would of course still be blocking. WDYT?

Edit: Reading through some of the code, this is actually a 
`materializer.close()` for the Akka based client. That means we'll churn 
through Materializers in certain scenarios. Can you run the test suites against 
this change to see if that has any impact? IIRC Materializers are rather 
expensive to create.

[ Full content available at: 
https://github.com/apache/incubator-openwhisk/pull/3976 ]
This message was relayed via gitbox.apache.org for [email protected]

Reply via email to