@kamalcph thanks for the review and for letting me know about #5427, I'll keep in mind if I want to further refactor something. As far as I see though that PR doesn't aim to change this class and while we might be just doing this there I'd rather stand by not removing those bits from this commit if you don't insist. I generally think it's much simpler to go with smaller but reasonably sized commits as they are easier to review, less change at once, less chance for conflicts, easier to merge.
[ Full content available at: https://github.com/apache/kafka/pull/5548 ] This message was relayed via gitbox.apache.org for [email protected]
