> But with regard to my comments, I am wondering if we should add more tests to > check the behavior we want in a tighter fashion?
The tests I added in unit suite checks that 1) `idle time is respected, and timer is reset correctly once enforce has happened`, 2) optimization on skipping commit indeed happens. I think I can add more on 3) punctuate / commit happens as expected, 4) break loop and calls poll as expected. Anything else comes to your mind? @mjsax [ Full content available at: https://github.com/apache/kafka/pull/5428 ] This message was relayed via gitbox.apache.org for [email protected]
