@gigasquid ok we're good to go. I removed the pointless imperative function
version of arange-with-inference, so I only had to add a test to
`operator_test.clj`.
However, in doing this, I think I've picked up a problem with `approx=`, in
which it incorrectly returns true if one of the comparisands (is that a word??)
is shorter than the other, and differs in the remaining elements that the other
does not have.
For example, try change the test starting on line 200 to the following:
```
(deftest ones
(let [ones (sym/ones [2 2])
exec (sym/simple-bind ones (context/default-context))]
(is (approx= 1e-4
[1 1 1 1 9 9 9 9 9 9]
(-> exec (executor/forward) (executor/outputs) (first))))))
```
(I've introduced the 9 9 9 9 9 9 here). This test still passes.
I've reported the issue here:
https://github.com/apache/incubator-mxnet/issues/12320, and fixed it in this
PR. It doesn't produce any regressions, luckily!
If my new test looks good to you, we should be ready to merge!
[ Full content available at:
https://github.com/apache/incubator-mxnet/pull/12064 ]
This message was relayed via gitbox.apache.org for [email protected]
